PR Summary

As noted in the umbrella issue, not all of the kernels have OMP coverage, which means we are loosing some performance at higher thread counts, even if it's smaller a smaller runtime cost than some other sections.
Also with the addition of a local script for kernels, we need to move the SCRIPT_OPTIONS_DICT for mphys_kernel_mod from the global area to the kernels.
With the move to the head of PSyclone, 3.3.1, it seems that the options parameter passed to a transformation, no longer passes everything through, such as ignore_dependencies_for. I am aware that STFC are trying to deprecate the options dict in favor of explicit by optional parameters to all transformations. We can catch modifications in this PR.
As I'm already fixing some piping in the scripts, where sensible there is some housekeeping, and lifting duplicate scripts into the local script.

This PR Contains:

• OMP additions for the following kernels:
  • mphys_turb_gen_kernel_mod, lsp_prognostic_tnuc_kernel_mod, lw_rad_tile_kernel_mod (Note RESOLVE_IMPORTS errors with PSyclone Transmute #613), bm_kernel_mod, smith_kernel_mod, spectral_gwd_kernel_mod, photol_kernel_mod, tracer_mix_kernel_mod,
• Move SCRIPT_OPTIONS_DICT for mphys_kernel_mod to kernel - Moved up into Enable Transmute script for bl imp and exp kernels #361
• Update kernel local.py script for PSyclone 3.3.1. - Part moved up into Enable Transmute script for bl imp and exp kernels #361, part here.
• Update global.py script for PSyclone 3.3.1.
• Update pc2_conv_coupling_kernel_mod.py for PSyclone 3.3.1.
• Update lw_kernel_mod and sw_kernel_mod for PSyclone 3.3.1.
• Update conv_gr_kernel_mod for PSyclone 3.3.1. - Moved into update Transmute for conv_gr_kernel_mod #583
• Lift bm_tau_kernel_mod to use the local.py script as scripts are effectively identical.
• Lift jules_extra_kernel_mod to use the local.py script as scripts are effectively identical.
• Lift pc2_initiation_kernel_mod to use the local.py script as scripts are effectively identical.
• Lift sw_rad_tile_kernel_mod to use the local.py script as scripts are effectively identical.
• Lift jules_exp_kernel_mod to use the local.py script. Add checks for OMP ancestory for general safety, and option of pure call overrides to local.py script.
• Lift jules_imp_kernel_mod to use the local.py script as scripts are effectively identical.

CCE Issues currently with, but have still been captured in this ticket to be ready to be activated as needed :
aerosol_ukca_kernel_mod, conv_comorph_kernel_mod

Sci/Tech Reviewer:
Code Reviewer: Joseph Abram (@J-J-Abram)

Issue: #608
Umbrella: #424

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - add_omp_more_kernels/run3

Suite Information

Task Information

✅ succeeded tasks - 51

Test Suite Results - lfric_apps - add_omp_more_kernels/run4

Suite Information

Task Information

✅ succeeded tasks - 1592

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable